Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] v7.5.3 regression -valid fails on input that passed in v7.5.2 #580

Closed
1 task done
Tracked by #581
ob1 opened this issue Jun 27, 2023 · 0 comments · Fixed by #583
Closed
1 task done
Tracked by #581

[BUG] v7.5.3 regression -valid fails on input that passed in v7.5.2 #580

ob1 opened this issue Jun 27, 2023 · 0 comments · Fixed by #583
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@ob1
Copy link

ob1 commented Jun 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

semver.valid('0.0.0-928490632884417731e7af463c92b034d6a78268fc993bcb88a57944') passes on 7.5.2, returns null on 7.5.3.

suspecting #571 as the culprit

Expected Behavior

either it should pass on 7.5.3 or it's a breaking change that warrants a non-patch version bump

Steps To Reproduce

see "current behavior"

Environment

N/A IMO
@ob1 ob1 added Bug thing that needs fixing Needs Triage needs an initial review labels Jun 27, 2023
@ob1 ob1 mentioned this issue Jul 2, 2023
Merged
@Gornator Gornator mentioned this issue Jul 2, 2023
Closed
1 task
lukekarrys added a commit that referenced this issue Jul 7, 2023
@lukekarrys
fix: correctly parse long build ids as valid
f547cf6 
Fixes #580
@lukekarrys lukekarrys mentioned this issue Jul 7, 2023
Merged
@wraithgar wraithgar mentioned this issue Jul 7, 2023
Merged
wraithgar pushed a commit that referenced this issue Jul 7, 2023
@lukekarrys
fix: correctly parse long build ids as valid (#583)
99d8287 
Fixes #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly parse long build ids as valid npm/node-semver
1 participant
@ob1