Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove npm-use-webauthn header #53

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

jumoel
Copy link
Contributor

@jumoel jumoel commented Jun 24, 2022

What

Remove the npm-use-webauthn header.

Why

The npm-auth-type header set in the npm-registry-fetch package will be used instead.

References

@jumoel jumoel requested a review from a team as a code owner June 24, 2022 09:00
@jumoel jumoel changed the title refactor: Change 'npm-use-webauthn' header to 'npm-auth-type' refactor: Change npm-use-webauthn header to npm-auth-type Jun 24, 2022
@jumoel jumoel changed the title refactor: Change npm-use-webauthn header to npm-auth-type feat!: Change npm-use-webauthn header to npm-auth-type Jun 24, 2022
@darcyclarke
Copy link

Is there any tests we can write for this &/or is this essentially captured downstream in the npm-registry-fetch implementation?

The 'npm-auth-type' header set in the 'npm-registry-fetch' package will be used instead.
@jumoel jumoel force-pushed the jumoel/change-to-npm-auth-type-header branch from 85a6383 to 8c8c153 Compare June 27, 2022 09:59
@jumoel jumoel changed the title feat!: Change npm-use-webauthn header to npm-auth-type feat!: Remove npm-use-webauthn header Jun 27, 2022
@jumoel
Copy link
Contributor Author

jumoel commented Jun 27, 2022

@darcyclarke Your comment made me realise that we don't need this header after all, because we can use the header set in npm-registry-fetch instead.

I changed the PR to remove the header instead. It can be merged once the new release of npm-registry-fetch has landed.

@jumoel jumoel requested a review from darcyclarke June 27, 2022 10:02
@nlf nlf merged commit b701df2 into main Aug 2, 2022
@nlf nlf deleted the jumoel/change-to-npm-auth-type-header branch August 2, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants