Preserve git+https auth when provided #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes pacote use the git+https: url as the resolved value for known hosts when auth is provided. When auth is not provided, we store the ssh url as the resolved value, in order to maintain a canonical save value that is never git:// for known hosts. In order to fully fix npm/cli#2054, we will also need to have @npmcli/arborist store the git+https url in the package-lock.json and package.json if https auth is provided.
wraithgar
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes pacote use the git+https: url as the resolved value for known
hosts when auth is provided. When auth is not provided, we store the
ssh url as the resolved value, in order to maintain a canonical save
value that is never git:// for known hosts.
In order to fully fix npm/cli#2054, we will also need to have
@npmcli/arborist store the git+https url in the package-lock.json and
package.json if https auth is provided.
References