Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Multiple Funding Sources #68

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Nov 19, 2019

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

@darcyclarke darcyclarke added Agenda will be discussed at the Open RFC call semver:minor new backwards-compatible feature Enhancement new feature or improvement Needs Discussion is pending a discussion Release 6.x labels Nov 19, 2019
@ljharb
Copy link
Contributor Author

ljharb commented Nov 26, 2019

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

@mikemimik
Copy link

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
@ljharb
Copy link
Contributor Author

ljharb commented Jan 27, 2020

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Jan 28, 2020
@darcyclarke darcyclarke merged commit 116a216 into npm:latest Feb 5, 2020
@ljharb ljharb deleted the multiple-funding-sources branch February 5, 2020 19:11
ljharb added a commit to ljharb/cli that referenced this pull request Feb 19, 2020
@darcyclarke darcyclarke removed the Agenda will be discussed at the Open RFC call label Feb 19, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Feb 19, 2020
darcyclarke pushed a commit to npm/cli that referenced this pull request Feb 25, 2020
See npm/rfcs#68

PR-URL: #731
Credit: @
Close: #731
Reviewed-by: @darcy Clarke

## Prior Art

- The `repository` field works in this same manner; it can be a string, an object, or an array of either.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

Copy link
Contributor Author

@ljharb ljharb Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.

It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaa. Good catch, huh?

Cool, everything is clear now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants