Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated node-gyp to 8.1.0 #32

Closed
wants to merge 1 commit into from
Closed

Updated node-gyp to 8.1.0 #32

wants to merge 1 commit into from

Conversation

darkmatter18
Copy link

What / Why

  • Updating the node-gyp version to 8.1.0
  • Many packages depend on run-script, so being a major package, it's so bad to use a deprecated package
  • That's why I updated the node-gyp to 8.1.0

References

Related to #25
Fixes #25
Closes #25

@wraithgar
Copy link
Member

Because our support contract in npm includes >=10, we can not update node-gyp to v 8 until we drop v10 support.

node-gyp@8 requires >= 10.12.0 of nodejs because it uses the recursive flag for mkdir:

https://github.com/nodejs/node-gyp/blob/5f1a06c50f3b0c3d292f64948f85a004cfcc5c87/lib/configure.js#L75

@silkfire
Copy link

@wraithgar When will npm drop v10 support?

@bedwardly-down
Copy link

bedwardly-down commented Sep 23, 2021

@wraithgar Currently doing some research on this issue and testing some small things out (seeing request as a dependency bugs me for my own uses). I'm looking into figuring a replacement that could work instead.

Findings:

  • Axios 0.21.4 (current version) tests without issues on Node 10.0.0 even though it doesn't explicitly state what versions it supports
  • Latest release of tap has several failures on Node 10.0.0 but the version used here seems to not like Axios
  • Postman and Cypress, two of the more popular modern request forks that seem to be getting fairly regular maintenance, rely on dependencies such as karma-tap which npm suggests to avoid installing

@wraithgar
Copy link
Member

Next month we are planning on cutting npm@8 which drops node 10 support. node-gyp@8 will be a part of that release and we will stay current w/ node-gyp as long as it doesn't drop support for any node12 before it went LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade node-gyp to v.8.0.0 to prevent deprecation errors
4 participants