Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Overrides Support #343

Closed
10 tasks done
darcyclarke opened this issue Apr 14, 2021 · 5 comments
Closed
10 tasks done

Epic: Overrides Support #343

darcyclarke opened this issue Apr 14, 2021 · 5 comments
Assignees
Labels

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Apr 14, 2021

Problem statement

Users want the ability to override/dependencies as they are being resolved.

Features

  • a user is able to define a set of overrides in package.json that will resolve dependencies differently at specific points in the tree

Exit criteria

  • RFC doc is accepted
  • feature-set is fully implemented/functioning
    • overrides propagate through tree at load
    • edges are marked invalid if override is not met
    • removing a node removes its overrides
    • adding overrides to a node copies them to all of its edgesOut
    • nodeFromEdge in build-ideal-tree takes overrides into account
    • CanPlaceDep/PlaceDep verify that placing nodes does not violate overrides
  • tests are written for coverage of this feature-set
  • documentation has been updated for package.json (ie. adding a section specifically for overrides)

Useful Links

@Haprog
Copy link

Haprog commented Apr 23, 2021

I think the RFC link in the description can be updated to https://github.com/npm/rfcs/blob/latest/accepted/0036-overrides.md (as the RFC PR has now been closed and moved to accepted).

@fernandopasik
Copy link

Any chance this will go any time soon into the https://github.com/npm/roadmap/projects/1 ?

@darcyclarke
Copy link
Contributor Author

For historical reference: #377

@Haprog
Copy link

Haprog commented Dec 14, 2021

Thanks a lot to everybody involved for making this happen!

@piotr-cz
Copy link

This is included in npm v8.3.0 (2021-12-09)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants