Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ansi-regex resolution #138

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

yowainwright
Copy link
Owner

@yowainwright yowainwright commented Nov 16, 2021

Fixes

cc: @StudioMaX @apepper


Read about referenced issues here. Replace words with this Pull Request's context.

@yowainwright yowainwright marked this pull request as ready for review November 16, 2021 06:20
@yowainwright yowainwright self-assigned this Nov 16, 2021
@yowainwright yowainwright added the bug Something isn't working label Nov 16, 2021
@apepper
Copy link

apepper commented Nov 16, 2021

Good to see progress in this area!

AFAIK resolutions is a yarn only feature (see e.g. https://stackoverflow.com/q/52416312 ). There is an overrides npm flag in the making but it will probably take weeks to months until this is implemented.

@yowainwright
Copy link
Owner Author

@apepper pnpm supports resolutions too.

View the pnpm-lock.yaml in this PR for reference. 👍

@yowainwright yowainwright merged commit 1e2ba78 into master Nov 17, 2021
@yowainwright yowainwright deleted the try-to-protect-ansi-regex branch November 17, 2021 14:49
@apepper
Copy link

apepper commented Feb 25, 2022

Npm's "overrides" is now available. I created a pull-request to fix the warning for npm - #155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some action needed to update the vulnerable ansi-regex package
2 participants