Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting #111

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix: linting #111

merged 1 commit into from
Aug 16, 2022

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner August 16, 2022 16:46
@wraithgar wraithgar merged commit c8ef004 into main Aug 16, 2022
@wraithgar wraithgar deleted the gar/lint branch August 16, 2022 17:10
@vit100
Copy link

vit100 commented Sep 15, 2022

this PR introduced issue
try catch (_){} changed to try catch {}
And this feature is supported only from node 10..

@wraithgar
Copy link
Member Author

The engines declaration on this module is "node": "^12.13.0 || ^14.15.0 || >=16.0.0", support for node 10 and lower was dropped in v4.0.0.

@vit100
Copy link

vit100 commented Sep 16, 2022

yeh, it is true,
but before this change code was working in node 8.

also this code is still compatible with node 8, line 22..

  } catch (e) {
    // worker_threads are not available, fallback to 0
    return 0
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants