Fixed PHP 5.6 Strict Standards Error

[mikeschinkel]

When using PHP 5.6 or PHP 7.0 and debugging options as follows set on the NPR Story API plugin currently throws errors.

define( 'WP_DEBUG', true );
ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL);

You can see the errors shown in this PDF file; look for the first two errors.

[benlk]

This adds an opening <p> - are the closing </p>s added anywhere?

[benlk]

Looks good to me, with the exception of that possibly-not-closed <p>.

[benlk]

In PHP 5.3, this error still shows:

PHP Notice:  Undefined property: stdClass::$url in /vagrant/wp-content/plugins/WP-DS-NPR-API/classes/NPRAPI.php on line 164, referer: http://vagrant.dev/wp-admin/options-general.php?page=ds_npr_api_get_multi_settings

https://github.com/newclarity/nprapi-wordpress/blob/2736600801384c65604b40362ea022044e077a3f/classes/NPRAPI.php#L164 :

      if (empty($this->request->params) && !stristr($this->request->url, 'sort=')){
        $this->stories = array_reverse($this->stories);
      } 

[mikeschinkel]

@benlk

PHP Notice: Undefined property: stdClass::$url...

That was outside the scope of my changes. However, 2f35137 which is now part of this PR hopefully resolves that issue?

[mikeschinkel]

@benlk As you can see the old code did not close <p>s either!

I was trying to limit the scope of my changes to just solve the solving the "Trying to get property of non-object" errors because I know it is easier to accept fixes when they are small.

That said, I'll add another commit that should add </p> closing tag.

[benlk]

No more errors here!

[mikeschinkel]

Anything else needed to merge this?