Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hk] validatation of constructor args #10

Merged
merged 1 commit into from
May 16, 2018
Merged

[hk] validatation of constructor args #10

merged 1 commit into from
May 16, 2018

Conversation

fgdrf
Copy link

@fgdrf fgdrf commented May 15, 2018 •
edited
Loading

  • constructor args validation
  • usage of xpath rather than values

Signed-off-by: Frank Gasdorf [email protected]

@fgdrf fgdrf mentioned this pull request May 16, 2018
Merged
@fgdrf
Copy link
Author

fgdrf commented May 16, 2018 •
edited
Loading

Brought back constructor I deleted before ..

@nprigour nprigour merged commit 98906a7 into nprigour:SetAttributesCommand-fix May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgdrf @nprigour