-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable bootloader #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonfam
requested review from
anangl,
carlescufi,
ioannisg and
SebastianBoe
as code owners
November 23, 2018 15:04
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SebastianBoe
suggested changes
Nov 26, 2018
sigvartmh
added a commit
to sigvartmh/fw-nrfconnect-zephyr
that referenced
this pull request
Nov 27, 2018
Remove linker script define from zephyr CMAKE and pushes and pops it to the global define instead. This commit fixes: nrfconnect/sdk-zephyr#53 (comment) Signed-off-by: Sigvart Hovland <[email protected]>
ioannisg
previously requested changes
Nov 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues reported (went through the core ARM code only)
This comment has been minimized.
This comment has been minimized.
cc @pizi-nordic |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nvlsianpu
reviewed
Dec 3, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pizi-nordic
reviewed
Dec 3, 2018
ioannisg
reviewed
Dec 4, 2018
This comment has been minimized.
This comment has been minimized.
SebastianBoe
approved these changes
Dec 4, 2018
This comment has been minimized.
This comment has been minimized.
Verified with nRF9160 PCA10090 and nRF52840 PCA10056 |
Add required overlay files for building with bootloader. Signed-off-by: Håkon Øye Amundsen <[email protected]>
Add firmware metadata section used by bootloader. Signed-off-by: Håkon Øye Amundsen <[email protected]>
carlescufi
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked with nrfconnect/sdk-nrf#256
and https://github.com/NordicPlayground/nrfxlib/pull/19
The goal of this solution is to allow the user to enable Secure Boot (with root of trust) with a single checkbox in Kconfig. After that, everything should be automatic and handled by the build system.
The changes needed in the zephyr repo is mostly related to being able to do proper linking, some build system changes to get control where we need it, and modifications to zephyrs startup code so its C runtime setup can be re used.
To test
Build
samples/hello_world
and set the"Nordic nRF Connect" --> "Secure Boot"
(SECURE_BOOT
) option in Kconfig.