Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable bootloader #53

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Immutable bootloader #53

merged 2 commits into from
Dec 7, 2018

Conversation

hakonfam
Copy link
Contributor

@hakonfam hakonfam commented Nov 23, 2018

Linked with nrfconnect/sdk-nrf#256
and https://github.com/NordicPlayground/nrfxlib/pull/19

The goal of this solution is to allow the user to enable Secure Boot (with root of trust) with a single checkbox in Kconfig. After that, everything should be automatic and handled by the build system.

The changes needed in the zephyr repo is mostly related to being able to do proper linking, some build system changes to get control where we need it, and modifications to zephyrs startup code so its C runtime setup can be re used.

To test
Build samples/hello_world and set the "Nordic nRF Connect" --> "Secure Boot" (SECURE_BOOT) option in Kconfig.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@SebastianBoe

This comment has been minimized.

@hakonfam hakonfam changed the title [RFC] Immutable bootloader Immutable bootloader Nov 23, 2018
@hakonfam

This comment has been minimized.

CMakeLists.txt Outdated Show resolved Hide resolved
@SebastianBoe

This comment has been minimized.

@hakonfam

This comment has been minimized.

@SebastianBoe

This comment has been minimized.

cmake/dts.cmake Outdated Show resolved Hide resolved
sigvartmh added a commit to sigvartmh/fw-nrfconnect-zephyr that referenced this pull request Nov 27, 2018
Remove linker script define from zephyr CMAKE and pushes and
pops it to the global define instead.

This commit fixes:
nrfconnect/sdk-zephyr#53 (comment)

Signed-off-by: Sigvart Hovland <[email protected]>
Copy link
Contributor

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues reported (went through the core ARM code only)

arch/arm/core/cortex_m/reset.S Outdated Show resolved Hide resolved
arch/arm/core/cortex_m/vector_table.S Outdated Show resolved Hide resolved
@SebastianBoe

This comment has been minimized.

@nvlsianpu
Copy link
Contributor

cc @pizi-nordic

@nvlsianpu

This comment has been minimized.

@carlescufi

This comment has been minimized.

@SebastianBoe

This comment has been minimized.

@hakonfam

This comment has been minimized.

@hakonfam

This comment has been minimized.

@carlescufi

This comment has been minimized.

@hakonfam

This comment has been minimized.

dts/common/secureboot.overlay Show resolved Hide resolved
ext/debug/segger/rtt/SEGGER_RTT.h Outdated Show resolved Hide resolved
ext/debug/segger/rtt/SEGGER_RTT_printf.c Outdated Show resolved Hide resolved
ext/hal/nordic/nrfx/hal/nrf_acl.h Outdated Show resolved Hide resolved
scripts/mergehex.py Outdated Show resolved Hide resolved
@hakonfam

This comment has been minimized.

@hakonfam hakonfam changed the base branch from master to nrf91 December 4, 2018 13:11
@carlescufi

This comment has been minimized.

@hakonfam
Copy link
Contributor Author

hakonfam commented Dec 7, 2018

Verified with nRF9160 PCA10090 and nRF52840 PCA10056

Add required overlay files for building with bootloader.

Signed-off-by: Håkon Øye Amundsen <[email protected]>
Add firmware metadata section used by bootloader.

Signed-off-by: Håkon Øye Amundsen <[email protected]>
@carlescufi carlescufi dismissed ioannisg’s stale review December 7, 2018 10:05

comments addressed

@carlescufi carlescufi merged commit 15c23c3 into nrfconnect:nrf91 Dec 7, 2018
@hakonfam hakonfam deleted the PR/pr0_RFC branch December 15, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants