fix(repo-server): excess git requests, improve cache performance by adding two level cache #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes argoproj#14725
Fourth part of a split of the argoproj#16309 and follow-up to argoproj#16410
Another piece of the fixes for argoproj#14725. This PR improves the cache performance and removes the added overhead from introducing the cache level lock to solve the excess ls-remote calls
CacheActionOpts
introduced in part 3 to addCacheType
. This field can be used to skip the local in-memory or external cache allowing us to replace current redis only caches with two level caches in place without having to swap everything over to using both.CacheType
action optionGet
call to match theSet
call interface with just a singleItem
input which accepts the action options.Baseline v2.9.0 with 200 multi-source applications with a ref only source:
With all of the changes from the original PR:
Checklist: