Skip to content

Commit

Permalink
fix(core): Remove warning when Nx is not installed globally (#28868)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
xiongemi authored Nov 11, 2024
1 parent d4b9e0d commit 18bba6f
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 32 deletions.
3 changes: 0 additions & 3 deletions packages/create-nx-plugin/bin/create-nx-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { createWorkspace, CreateWorkspaceOptions } from 'create-nx-workspace';
import { output } from 'create-nx-workspace/src/utils/output';
import { NxCloud } from 'create-nx-workspace/src/utils/nx/nx-cloud';
import type { PackageManager } from 'create-nx-workspace/src/utils/package-manager';
import { showNxWarning } from 'create-nx-workspace/src/utils/nx/show-nx-warning';
import {
messages,
recordStat,
Expand Down Expand Up @@ -150,8 +149,6 @@ async function main(parsedArgs: yargs.Arguments<CreateNxPluginArguments>) {
populatedArguments
);

showNxWarning(parsedArgs.pluginName);

await recordStat({
nxVersion,
command: 'create-nx-workspace',
Expand Down
3 changes: 0 additions & 3 deletions packages/create-nx-workspace/bin/create-nx-workspace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {
withOptions,
withPackageManager,
} from '../src/internal-utils/yargs-options';
import { showNxWarning } from '../src/utils/nx/show-nx-warning';
import { messages, recordStat } from '../src/utils/nx/ab-testing';
import { mapErrorToBodyLines } from '../src/utils/error-utils';
import { existsSync } from 'fs';
Expand Down Expand Up @@ -223,8 +222,6 @@ async function main(parsedArgs: yargs.Arguments<Arguments>) {
parsedArgs
);

showNxWarning(parsedArgs.name);

await recordStat({
nxVersion,
command: 'create-nx-workspace',
Expand Down
26 changes: 0 additions & 26 deletions packages/create-nx-workspace/src/utils/nx/show-nx-warning.ts

This file was deleted.

0 comments on commit 18bba6f

Please sign in to comment.