feat(bundling): add createNodesV2 for rollup plugin

nrwl · Sep 24, 2024 · 98c3b4d · 98c3b4d
1 parent 6182d20
commit 98c3b4d
Show file tree

Hide file tree

Showing 4 changed files with 216 additions and 106 deletions.
diff --git a/packages/rollup/plugin.ts b/packages/rollup/plugin.ts
@@ -1 +1,5 @@
-export { createNodes, RollupPluginOptions } from './src/plugins/plugin';
+export {
+  createNodes,
+  createNodesV2,
+  RollupPluginOptions,
+} from './src/plugins/plugin';
diff --git a/packages/rollup/src/plugins/__snapshots__/plugin.spec.ts.snap b/packages/rollup/src/plugins/__snapshots__/plugin.spec.ts.snap
@@ -1,70 +1,110 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`@nx/rollup/plugin non-root project should create nodes 1`] = `
-{
-  "projects": {
-    "mylib": {
-      "root": "mylib",
-      "targets": {
-        "build": {
-          "cache": true,
-          "command": "rollup -c rollup.config.js",
-          "dependsOn": [
-            "^build",
-          ],
-          "inputs": [
-            "production",
-            "^production",
-            {
-              "externalDependencies": [
-                "rollup",
+[
+  [
+    "mylib/rollup.config.js",
+    {
+      "projects": {
+        "mylib": {
+          "root": "mylib",
+          "targets": {
+            "build": {
+              "cache": true,
+              "command": "rollup -c rollup.config.js",
+              "dependsOn": [
+                "^build",
+              ],
+              "inputs": [
+                "production",
+                "^production",
+                {
+                  "externalDependencies": [
+                    "rollup",
+                  ],
+                },
+              ],
+              "metadata": {
+                "description": "Run Rollup",
+                "help": {
+                  "command": "npx rollup --help",
+                  "example": {
+                    "options": {
+                      "sourcemap": true,
+                      "watch": true,
+                    },
+                  },
+                },
+                "technologies": [
+                  "rollup",
+                ],
+              },
+              "options": {
+                "cwd": "mylib",
+              },
+              "outputs": [
+                "{workspaceRoot}/mylib/build",
+                "{workspaceRoot}/mylib/dist",
               ],
             },
-          ],
-          "options": {
-            "cwd": "mylib",
           },
-          "outputs": [
-            "{workspaceRoot}/mylib/build",
-            "{workspaceRoot}/mylib/dist",
-          ],
         },
       },
     },
-  },
-}
+  ],
+]
 `;
 
 exports[`@nx/rollup/plugin root project should create nodes 1`] = `
-{
-  "projects": {
-    ".": {
-      "root": ".",
-      "targets": {
-        "build": {
-          "cache": true,
-          "command": "rollup -c rollup.config.js",
-          "dependsOn": [
-            "^build",
-          ],
-          "inputs": [
-            "production",
-            "^production",
-            {
-              "externalDependencies": [
-                "rollup",
+[
+  [
+    "rollup.config.js",
+    {
+      "projects": {
+        ".": {
+          "root": ".",
+          "targets": {
+            "build": {
+              "cache": true,
+              "command": "rollup -c rollup.config.js",
+              "dependsOn": [
+                "^build",
+              ],
+              "inputs": [
+                "production",
+                "^production",
+                {
+                  "externalDependencies": [
+                    "rollup",
+                  ],
+                },
+              ],
+              "metadata": {
+                "description": "Run Rollup",
+                "help": {
+                  "command": "npx rollup --help",
+                  "example": {
+                    "options": {
+                      "sourcemap": true,
+                      "watch": true,
+                    },
+                  },
+                },
+                "technologies": [
+                  "rollup",
+                ],
+              },
+              "options": {
+                "cwd": ".",
+              },
+              "outputs": [
+                "{workspaceRoot}/dist",
               ],
             },
-          ],
-          "options": {
-            "cwd": ".",
           },
-          "outputs": [
-            "{workspaceRoot}/dist",
-          ],
         },
       },
     },
-  },
-}
+  ],
+]
 `;
diff --git a/packages/rollup/src/plugins/plugin.spec.ts b/packages/rollup/src/plugins/plugin.spec.ts
@@ -1,5 +1,5 @@
 import { type CreateNodesContext } from '@nx/devkit';
-import { createNodes } from './plugin';
+import { createNodesV2 } from './plugin';
 import { TempFs } from 'nx/src/internal-testing-utils/temp-fs';
 
 // Jest 29 does not support dynamic import() unless --experimental-vm-modules is set.
@@ -11,7 +11,7 @@ jest.mock('rollup/loadConfigFile', () => {
 });
 
 describe('@nx/rollup/plugin', () => {
-  let createNodesFunction = createNodes[1];
+  let createNodesFunction = createNodesV2[1];
   let context: CreateNodesContext;
   let cwd = process.cwd();
 
@@ -77,7 +77,7 @@ describe('@nx/rollup/plugin', () => {
     it('should create nodes', async () => {
       // ACT
       const nodes = await createNodesFunction(
-        'rollup.config.js',
+        ['rollup.config.js'],
         {
           buildTargetName: 'build',
         },
@@ -154,7 +154,7 @@ describe('@nx/rollup/plugin', () => {
     it('should create nodes', async () => {
       // ACT
       const nodes = await createNodesFunction(
-        'mylib/rollup.config.js',
+        ['mylib/rollup.config.js'],
         {
           buildTargetName: 'build',
         },