Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nrwl/angular:storybook-configuration schematic adds old version of Storybook to package.json #4313

Closed
PerKjaer opened this issue Dec 16, 2020 · 4 comments · Fixed by #4335
Closed
Assignees
Labels
outdated scope: storybook Issues related to Storybook support in Nx type: bug

Comments

@PerKjaer
Copy link

Current Behavior

When you use @nrwl/angular:storybook-configuration to add Storybook support to an Angular 11 app or lib, the following lines are added to package.json:

"@storybook/addon-knobs": "^6.0.21",
"@storybook/angular": "^6.0.21",

Version 6.0.21 of Storybook does not work with Angular 11. Storybook only works because npm will install the newest compatible version of Storybook.

Expected Behavior

A version of Storybook that is compatible with Angular 11 should be added to package.json.

Steps to Reproduce

  • Create a nx workspace containing an Angular app
  • Add @nrwl/storybook to packages.json
  • Run npm install
  • Run the @nrwl/angular:storybook-configuration schematic to add Storybook configuration to the app

Failure Logs

Environment

Node : 12.20.0
OS : win32 x64
npm : 6.14.9

nx : Not Found
@nrwl/angular : 11.0.8
@nrwl/cli : 11.0.8
@nrwl/cypress : 11.0.8
@nrwl/devkit : 11.0.8
@nrwl/eslint-plugin-nx : Not Found
@nrwl/express : Not Found
@nrwl/jest : 11.0.8
@nrwl/linter : 11.0.8
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/react : Not Found
@nrwl/schematics : Not Found
@nrwl/tao : 11.0.8
@nrwl/web : Not Found
@nrwl/workspace : 11.0.8
typescript : 4.0.5

@vsavkin vsavkin added the scope: storybook Issues related to Storybook support in Nx label Dec 16, 2020
@mehrad-rafigh
Copy link
Contributor

mehrad-rafigh commented Dec 16, 2020

@PerKjaer I had to install v6.2.0-alpha.6 to get it working again. Can you please confirm? I would create a PR for this if having an alpha is not an issue @vsavkin

Issue over at Storybook

@PerKjaer
Copy link
Author

I have it working with Storybook v6.1.11.

It is this bug you get when using the old version of Storybook: storybookjs/storybook#13093

@mehrad-rafigh
Copy link
Contributor

@PerKjaer Alright then. I will update storybook to v6.1.11

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: storybook Issues related to Storybook support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants