Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): update storybook to v6.1.11 #4329

Closed
wants to merge 1 commit into from
Closed

feat(storybook): update storybook to v6.1.11 #4329

wants to merge 1 commit into from

Conversation

mehrad-rafigh
Copy link
Contributor

Current Behavior

Storybook v6.0.2 causes an error

Expected Behavior

Storybook v6.1.11 fixes the error

Related Issue(s)

#4313

Fixes #
#4313

@mehrad-rafigh
Copy link
Contributor Author

@FrozenPandaz @vsavkin Can you please review this?

@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2020

Nx Cloud Report

CI ran the following commands for commit df9f8ee. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base angular 12/17/2020, 5:14:39 PM
#000000 nx build-base cypress 12/17/2020, 5:14:32 PM
#000000 nx build-base next 12/17/2020, 5:12:40 PM
#000000 nx build-base react 12/17/2020, 5:14:55 PM
#000000 nx build-base storybook 12/17/2020, 5:14:39 PM
#000000 nx build-base web 12/17/2020, 5:14:39 PM
#000000 nx run-many --target=build --all --parallel 12/17/2020, 5:12:22 PM
#000000 nx run-many --target=e2e --projects=e2e-angular 12/17/2020, 5:15:12 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress 12/17/2020, 5:13:18 PM
#000000 nx run-many --target=e2e --projects=e2e-next 12/17/2020, 5:15:19 PM
#000000 nx run-many --target=e2e --projects=e2e-react 12/17/2020, 5:13:10 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-storybook 12/17/2020, 5:12:52 PM
#000000 nx run-many --target=test --all --parallel 12/17/2020, 5:12:42 PM

Sent with 💌 from NxCloud.

@FrozenPandaz
Copy link
Collaborator

Thank for your contribution!

Unfortunately, I already handled this in #4335

The migration was a little more nuanced than always updating storybook for all users. We allow users to stay on storybook 5 so we needed to check that.

Thank you for taking a look though!

@mehrad-rafigh mehrad-rafigh deleted the feat/update-storybook-to-6-1-11 branch December 18, 2020 09:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants