Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nx): pass generic to CreateNodes #22157

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

bacarybruno
Copy link
Contributor

Current Behavior

The NxPluginV2 type takes a generic representing the plugin options, but doesn't pass it to the CreateNodes type. This creates a small type issue, as the options on the CreateNodes type is unknown.

Expected Behavior

The options on the CreateNodes type is well typed

@bacarybruno bacarybruno requested a review from a team as a code owner March 5, 2024 11:48
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 5, 2024 5:09pm

@bacarybruno bacarybruno requested review from a team as code owners March 5, 2024 17:03
@AgentEnder AgentEnder merged commit 3b2e5a8 into nrwl:master Mar 5, 2024
6 checks passed
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Mar 8, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants