fix(core): task graph needs to handle multiple cycles #28793
Merged
+487
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c46dd42. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
fix/fix-add-seen-get-dep
branch
from
5761b26
to
5a2301d
Compare
xiongemi
changed the title
xiongemi
force-pushed
the
fix/fix-add-seen-get-dep
branch
from
5a2301d
to
3c45083
Compare
jaysoo
reviewed
Nov 5, 2024
|
Failed to publish a PR release of this pull request, triggered by @xiongemi. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28793-3c45083
To request a new release for this pull request, mention someone from the Nx team or the |
xiongemi
force-pushed
the
fix/fix-add-seen-get-dep
branch
from
3c45083
to
a0259ac
Compare
jaysoo
reviewed
Nov 6, 2024
xiongemi
force-pushed
the
fix/fix-add-seen-get-dep
branch
from
a0259ac
to
c46dd42
Compare
Cammisuli
approved these changes
Nov 6, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 6, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - getNonDummyDeps is a recursive function. we pass in cycle arg to this function. currently we end the recursion when the task is in a cycle. however, currently there is an error "Maximum call stack size". i suspect this recursion is not being ended because the cycle is not detected when there are multiple cycles. - add a function to get all cycles of the graph - also, change getNonDummyDeps to track a list of seen tasks, even with no cycle detected, this function will not run into infinite recursion ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28788 (cherry picked from commit 9c24566)
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 12, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - getNonDummyDeps is a recursive function. we pass in cycle arg to this function. currently we end the recursion when the task is in a cycle. however, currently there is an error "Maximum call stack size". i suspect this recursion is not being ended because the cycle is not detected when there are multiple cycles. - add a function to get all cycles of the graph - also, change getNonDummyDeps to track a list of seen tasks, even with no cycle detected, this function will not run into infinite recursion ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28788 (cherry picked from commit 9c24566)
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #28788