fix(core): set default branch to main if no git #28854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b0ee13e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Nov 8, 2024
| @@ -65,6 +65,15 @@ export function createNxJsonFile( | |||
| } | |||
|
|
|||
| function deduceDefaultBase() { | |||
| try { | |||
There was a problem hiding this comment.
We shouldn't have to run a different command to make sure git doesn't exist...
Can we check the error some how?
We're running git in the line below.. that will error if there's no git... can we somehow check the first error to see if it says that git is not installed?
Also it seems like the final catch here says to return master... so maybe this should return master too? 👀 I don't know if now is the time to change that return to main
xiongemi
force-pushed
the
feature/nxc-1180-defaultbase-should-be-main-by-default
branch
from
535c76a
to
4abe575
Compare
xiongemi
force-pushed
the
feature/nxc-1180-defaultbase-should-be-main-by-default
branch
from
4abe575
to
b0ee13e
Compare
FrozenPandaz
approved these changes
Nov 12, 2024
FrozenPandaz
deleted the
feature/nxc-1180-defaultbase-should-be-main-by-default
branch
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 13, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 2d77495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #