feat(testing): add projects into jest config #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cammisuli
force-pushed
the
jest-projects
branch
from
20ac78c
to
a9ce7e8
Compare
Nx Cloud ReportCI ran the following commands. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
4 tasks
FrozenPandaz
approved these changes
Sep 22, 2020
| @@ -1,3 +1,4 @@ | |||
| import { tags } from '@angular-devkit/core'; | |||
| @@ -67,6 +69,7 @@ function run( | |||
| useStderr: options.useStderr, | |||
| watch: options.watch, | |||
| watchAll: options.watchAll, | |||
| projects: [options.jestConfig], | |||
There was a problem hiding this comment.
I don't think this was necessary.
Doginal
pushed a commit
to Doginal/nx
that referenced
this pull request
Nov 25, 2020
* feat(testing): add projects into jest config * chore(testing): update unit tests and fix presets with spreading a default * chore(testing): fix node e2e * chore(testing): review comment changes
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Jest configs are independant, and cannot be run from the root of the workspace with just
jest. This causes some issues with VsCode extensions.Expected Behavior
The root jest.config.js file now contains references to all jest projects in the workspace. A new jest.preset.js file is created as well where each project config has this as a preset.
Related Issue(s)
Closes #747
Closes #1506
Closes #2377
Closes #2344
Closes #2635
Closes #3507