Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix up data.source.update #38

Merged
merged 3 commits into from
Sep 4, 2019
Merged

fix up data.source.update #38

merged 3 commits into from
Sep 4, 2019

Conversation

rupa
Copy link
Contributor

@rupa rupa commented Sep 3, 2019

  • sourcetype must be passed (although it cannot be changed)
  • id does not need to be passed as data (it's in the URL)
  • add unit tests for data.source
  • docs updates

@rupa
fix up data.source.update
968e7a9 
* sourcetype must be passed (although it cannot be changed)
* id does not need to be passed as data (it's in the URL)
* add unit tests for data.source
* docs updates
@rupa rupa requested a review from mburtless September 3, 2019 20:45
mburtless
mburtless reviewed Sep 3, 2019
View reviewed changes
README.rst Show resolved Hide resolved
mburtless
mburtless approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@mburtless mburtless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupa rupa merged commit ebae735 into ns1:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburtless mburtless mburtless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupa @mburtless