Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-131: support monitoring regions and jobtypes endpoint #55

Merged
merged 6 commits into from
Feb 12, 2020

Conversation

rupa
Copy link
Contributor

@rupa rupa commented Feb 3, 2020

Support for these endpoints added to rest.monitoring as classes,
with "high-level" entry points to the classes

Did not add "high level" methods for the class methods - doesn't seem worth it
unless we want to make models for the responses, and I don't see why we
would.

Also put together basic tests for the rest/monitoring file as a whole, and started a test file for ns1/__init__

Support for these endpoints added to rest.monitoring.Monitors, as
properties. e.g.:

* client.monitors().jobtypes
* client.monitors().regions

Did not add "high level" methods for these - doesn't seem worth it
unless we want to make models for the responses, and I don't see why we
would.

Also put together basic tests for the rest/monitoring file as a whole.
ns1/rest/monitoring.py Outdated Show resolved Hide resolved
rupa deadwyler added 4 commits February 3, 2020 17:44
Make separate classes for JobTypes and Regions, with list methods, rather
than trying to shoehorn them in to the Monitors class and get fancy with
properties to delineate these methods from the standard CRUD methods of
another resource.
Adds methods to NS1 class
  * monitoring_jobtypes: returns ns1.rest.monitoring.JobTypes
  * monitoring_regions: returns ns1.rest.monitoring.Regions

Also started some tests for ns1/__init__
ns1/__init__.py Outdated Show resolved Hide resolved
ns1/__init__.py Outdated Show resolved Hide resolved
ns1/__init__.py Outdated Show resolved Hide resolved
ns1/__init__.py Outdated Show resolved Hide resolved
@rupa rupa merged commit f96e177 into master Feb 12, 2020
@rupa rupa deleted the monitoring_endpoints branch February 12, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants