Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binary object transmission #436

Closed
wants to merge 5 commits into from

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Nov 15, 2023

currently experimental

@cthulhu-rider cthulhu-rider marked this pull request as draft November 15, 2023 18:02
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (a900856) 63.72% compared to head (8913173) 63.80%.
Report is 13 commits behind head on master.

❗ Current head 8913173 differs from pull request most recent head 54389e4. Consider uploading reports for the commit 54389e4 to get more accurate results

Files Patch % Lines
rpc/client/init.go 0.00% 15 Missing ⚠️
rpc/client/call_options.go 0.00% 3 Missing ⚠️
netmap/marshal.go 0.00% 2 Missing ⚠️
container/marshal.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   63.72%   63.80%   +0.08%     
==========================================
  Files          75       75              
  Lines        9380     9397      +17     
==========================================
+ Hits         5977     5996      +19     
+ Misses       2689     2684       -5     
- Partials      714      717       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is the latest revision at the moment. Related upgrades:
 * `github.com/stretchr/testify` -> `v1.8.4`
 * `google.golang.org/protobuf` -> `v1.31.0`

Signed-off-by: Leonard Lyubich <[email protected]>
Add `client.SyncWrite` option constructor that makes message
transmission methods to wait for the message to be completely written
out to the underlying connection.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider force-pushed the feature/object-binary-transmission branch from 7947b4a to 3118b92 Compare November 23, 2023 19:29
@cthulhu-rider
Copy link
Contributor Author

@roman-khimov roman-khimov deleted the feature/object-binary-transmission branch June 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant