Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move contract deployment #395

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Move contract deployment #395

merged 4 commits into from
Apr 27, 2024

Conversation

smallhive
Copy link
Contributor

Closes #394

@smallhive smallhive force-pushed the 394-move-contract-deployment branch from 2f5b8ab to 267503a Compare April 19, 2024 03:59
AnnaShaleva
AnnaShaleva reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way, I'm not doing this. If this code works, then just not touch it.

deploy/alphabet.go Outdated Show resolved Hide resolved
deploy/contracts.go Show resolved Hide resolved
deploy/util.go Show resolved Hide resolved
@roman-khimov
Copy link
Member

No way, I'm not doing this.

The only thing that works here is

$ diff -puraN ../neofs-node/pkg/morph/deploy/ deploy/

roman-khimov
roman-khimov reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see deploy_test.go and funds_test.go, likely they can be kept.

deploy/contracts.go Outdated Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
deploy/netmap.go Outdated Show resolved Hide resolved
deploy/rand.go Outdated Show resolved Hide resolved
deploy/contracts.go Outdated Show resolved Hide resolved
deploy/contracts.go Show resolved Hide resolved
@smallhive smallhive force-pushed the 394-move-contract-deployment branch from 040e372 to dfa91d4 Compare April 27, 2024 06:55
@smallhive smallhive force-pushed the 394-move-contract-deployment branch from dfa91d4 to cb6d9bd Compare April 27, 2024 06:58
@smallhive
Copy link
Contributor Author

I don't see deploy_test.go and funds_test.go, likely they can be kept.

Restored

@roman-khimov roman-khimov merged commit 286b141 into master Apr 27, 2024
10 checks passed
@roman-khimov roman-khimov deleted the 394-move-contract-deployment branch April 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move contract deployment/update code into this repository
3 participants
@smallhive @roman-khimov @AnnaShaleva