Deprecate peapod, provide migration to fstree

[End-rey]

Closes #2924.

Is there anything else I should do in this pr?

[codecov]

Codecov Report

Attention: Patch coverage is 27.38589% with 175 lines in your changes missing coverage. Please review.

Project coverage is 22.84%. Comparing base (31fa3b4) to head (4fb969a).
Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/peapod-to-fstree/main.go	27.73%	156 Missing and 16 partials ⚠️
cmd/neofs-node/validate.go	0.00%	1 Missing and 1 partial ⚠️
cmd/neofs-lens/internal/peapod/root.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3013      +/-   ##
==========================================
+ Coverage   22.82%   22.84%   +0.01%     
==========================================
  Files         790      791       +1     
  Lines       58362    58603     +241     
==========================================
+ Hits        13323    13389      +66     
- Misses      44157    44316     +159     
- Partials      882      898      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[carpawell]

I am almost sure we also want to migrate some metabase indexes in this util, otherwise i do not know who should do it.
See

neofs-node/pkg/local_object_storage/blobstor/get.go

Lines 19 to 32 in ba1d639

	if prm.StorageID == nil {
	for i := range b.storage {
	res, err := b.storage[i].Storage.Get(prm)
	if err == nil || !errors.As(err, new(apistatus.ObjectNotFound)) {
	return res, err
	}
	}
	return common.GetRes{}, logicerr.Wrap(apistatus.ObjectNotFound{})
	}
	if len(prm.StorageID) == 0 {
	return b.storage[len(b.storage)-1].Storage.Get(prm)
	}
	return b.storage[0].Storage.Get(prm)

,

neofs-node/pkg/local_object_storage/blobstor/peapod/peapod.go

Lines 422 to 425 in ba1d639

	return common.PutRes{
	StorageID: storageID,
	}, err
	}

and

neofs-node/pkg/local_object_storage/blobstor/fstree/fstree.go

Line 308 in ba1d639

return common.GetRes{Object: obj, RawData: data}, nil

[carpawell]

Linter feels bad.

[roman-khimov]

Not sure what can be affected by this.

[End-rey]

How can I easily get the epoch state in another way? The metabase requires it to be set.

[roman-khimov]

Only via network interaction. Maybe it's not a problem in our case (updating storage ID doesn't require epoch IIRC). Or maybe we can get some latest known one from meta or local state.

[End-rey]

I can get LastResyncEpoch from metabase:

neofs-node/pkg/local_object_storage/metabase/last_resync_epoch.go

Lines 12 to 14 in 45802c6

	// ReadLastResyncEpoch reads from db last epoch when metabase was resynchronized.
	// If id is missing, returns 0, nil.
	func (db *DB) ReadLastResyncEpoch() (epoch uint64, err error) {

But it will be necessary to recreate it after receiving an epoch.

[roman-khimov]

It's somewhat different in meaning and it's a new one, 0.43.0 DB doesn't have it.

[carpawell]

why do you need a precise epoch? just pick an epoch that does not claim anything about object expiration and allows GET and PUT freely, that is 0. @roman-khimov, what bothers you?

How can I easily get the epoch state in another way? The metabase requires it to be set.

i did this and i did not know there would be so many utils that just open metabases and look at them. normal metabase always has to know the current epoch (via internal state or via explicit parameter to every operation)

[carpawell]

i would recommend smth like

extension := filepath.Ext(srcPath)
name := srcPath[0:len(srcPath)-len(extension)]

dots are not prohibited in file names

[roman-khimov]

In general, you can just do + ".migrated" and that's it. srcPath can be anything, with many dots, without dots, whatever.