Update to API Go v1.28.1 #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 2, 2021 09:02
…equacy Create `version` package and implement `IsValid` function which checks if version is not earlier than the genesis one. Signed-off-by: Leonard Lyubich <[email protected]>
Extended ACL input can have version later than CLI one, and it should not be downgraded. But the version should be still adequate. Set `pkg.SDKVersion` on false return of `version.IsValid`. Signed-off-by: Leonard Lyubich <[email protected]>
…alNodeInfo Clients can have version later than the server. The server should not deny these clients. Signed-off-by: Leonard Lyubich <[email protected]>
Container can have version later than the current lib version, and it should not be considered as invalid. But it should still have adequate version. Signed-off-by: Leonard Lyubich <[email protected]>
Storage node should only reflect container Put requests to sidechain w/o any validation. All verification steps are performed by IR. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
upd-apigo-v1.28.1
branch
from
776ecc6
to
6cbcf82
Compare
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 43.05% 43.09% +0.04%
==========================================
Files 204 205 +1
Lines 8072 8078 +6
==========================================
+ Hits 3475 3481 +6
Misses 4256 4256
Partials 341 341
Continue to review full report at Codecov.
|
alexvanin
approved these changes
Jul 2, 2021
carpawell
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655.