Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/Skip audit for containers without SG #668

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix/Skip audit for containers without SG #668

merged 1 commit into from
Jul 6, 2021

Conversation

carpawell
Copy link
Member

Closes #659.

@carpawell carpawell added bug Something isn't working neofs-ir Inner Ring node application issues labels Jul 6, 2021
@carpawell carpawell added this to the v0.22.1 milestone Jul 6, 2021
@carpawell carpawell self-assigned this Jul 6, 2021
@carpawell carpawell marked this pull request as ready for review July 6, 2021 18:15
@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #668 (189e759) into master (3a7d7bd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   43.09%   43.08%   -0.02%     
==========================================
  Files         205      205              
  Lines        8078     8080       +2     
==========================================
  Hits         3481     3481              
- Misses       4256     4258       +2     
  Partials      341      341
Impacted Files Coverage Δ
pkg/innerring/processors/audit/process.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7d7bd...189e759. Read the comment docs.

@cthulhu-rider cthulhu-rider merged commit 0bcc505 into nspcc-dev:master Jul 6, 2021
@carpawell carpawell deleted the fix/do-not-audit-containers-without-sg branch July 15, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@alexvanin alexvanin Awaiting requested review from alexvanin

Assignees

@carpawell carpawell

Labels
bug Something isn't working neofs-ir Inner Ring node application issues
Projects
None yet
Milestone
v0.22.1
Development

Successfully merging this pull request may close these issues.

Empty containers produce audit results
2 participants
@carpawell @cthulhu-rider