Update to Go 1.21 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,8 @@ run: | |||
| # output configuration options | |||
| output: | |||
| # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number" | |||
| format: tab | |||
| formats: | |||
There was a problem hiding this comment.
Please at least reference similar PRs in other repos. Or better yet apply commits from @cthulhu-rider (like in nspcc-dev/rfc6979#8), they have perfect descriptions.
.github/workflows/run_tests.yml
Outdated
| @@ -77,7 +77,7 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| strategy: | |||
| matrix: | |||
| go_versions: [ '1.20', '1.21', '1.22' ] | |||
| go_versions: [ '1.21', '1.22', '1.23' ] | |||
There was a problem hiding this comment.
1.23 is a separate change, but we need to adapt to our new policy and drop one version from the set.
There was a problem hiding this comment.
Removed 1.23 and reduced to just couple versions
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.22-alpine as basebuilder | |||
| FROM golang:1.23-alpine as basebuilder | |||
There was a problem hiding this comment.
Not here, it's a part of #43.
Closes #34. Signed-off-by: Evgenii Baidakov <[email protected]>
Adapt to our new policy. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
According to https://golangci-lint.run/usage/linters/#govet, `check-shadowing` no longer exists. Now it should be ```yaml govet: disable: [shadow] ``` but `shadow` is disabled by default. Thus, whole `govet` section is not needed anymore. ``` $ golangci-lint --version golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z ``` Signed-off-by: Evgenii Baidakov <[email protected]>
This fixes ``` $ golangci-lint --version golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z $ golangci-lint run ./... WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` ``` The configuration file is updated according to https://golangci-lint.run/usage/configuration/. Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
34-go-121-update-check-list
branch
from
085227c
to
f1a2557
Compare
roman-khimov
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #34