Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign multipart objects in the gate #1001

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

smallhive
Copy link
Contributor

Closes #975.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 26.67%. Comparing base (bbde4d9) to head (b038931).
Report is 73 commits behind head on master.

Files with missing lines Patch % Lines
internal/neofs/neofs.go 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   26.63%   26.67%   +0.03%     
==========================================
  Files          88       88              
  Lines       14400    14564     +164     
==========================================
+ Hits         3836     3885      +49     
- Misses      10135    10244     +109     
- Partials      429      435       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/neofs/neofs.go Outdated Show resolved Hide resolved
internal/neofs/neofs.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 975-sign-multiparts-and-do-not-use-sessions branch 2 times, most recently from 502ef75 to e6d8cd8 Compare September 11, 2024 06:15
api/layer/object.go Outdated Show resolved Hide resolved
internal/neofs/neofs.go Outdated Show resolved Hide resolved
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we need some tests for it? Test code can be unified with SDK/node. Otherwise, it is impossible to keep everything in sync to me. Multiple codes do the same thing.

api/layer/object.go Outdated Show resolved Hide resolved
internal/neofs/neofs.go Outdated Show resolved Hide resolved
internal/neofs/neofs.go Outdated Show resolved Hide resolved
@smallhive
Copy link
Contributor Author

Dont we need some tests for it? Test code can be unified with SDK/node. Otherwise, it is impossible to keep everything in sync to me. Multiple codes do the same thing.

I checked the code with s3 gate tests locally and GH pipeline did it as well

@smallhive smallhive force-pushed the 975-sign-multiparts-and-do-not-use-sessions branch from e6d8cd8 to e59d186 Compare September 11, 2024 10:51
@carpawell
Copy link
Member

s3 gate tests locally and GH pipeline

@smallhive, i guess without #974 it also worked well but contained errors, right? I do not mean this must be done in this PR (at least something should appear in SDK) but I think we can discuss it at least. @roman-khimov

@smallhive smallhive force-pushed the 975-sign-multiparts-and-do-not-use-sessions branch from e59d186 to 0acc780 Compare September 12, 2024 06:02
@smallhive
Copy link
Contributor Author

@smallhive, i guess without #974 it also worked well but contained errors, right? I do not mean this must be done in this PR (at least something should appear in SDK) but I think we can discuss it at least. @roman-khimov

It's make sence

internal/neofs/neofs.go Outdated Show resolved Hide resolved
Closes #975.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive smallhive force-pushed the 975-sign-multiparts-and-do-not-use-sessions branch from 0acc780 to 4cff0fc Compare September 13, 2024 04:07
@roman-khimov roman-khimov merged commit 21e6a71 into master Sep 13, 2024
16 checks passed
@roman-khimov roman-khimov deleted the 975-sign-multiparts-and-do-not-use-sessions branch September 13, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign multiparts and do not use sessions
3 participants