Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write object payload if exists #822

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Write object payload if exists #822

merged 1 commit into from
Sep 12, 2023

Conversation

smallhive
Copy link
Contributor

closes #821

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #822 (b97b9bf) into master (986b9dd) will decrease coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   34.34%   34.33%   -0.02%     
==========================================
  Files          61       61              
  Lines       10481    10486       +5     
==========================================
  Hits         3600     3600              
- Misses       6480     6485       +5     
  Partials      401      401
Files Changed Coverage Δ
internal/neofs/neofs.go 1.43% <0.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smallhive smallhive force-pushed the 821-s3-panic-on-object-creation branch from eb42bc6 to 27779de Compare September 12, 2023 07:39
@smallhive smallhive marked this pull request as ready for review September 12, 2023 07:42
roman-khimov
roman-khimov reviewed Sep 12, 2023
View reviewed changes
internal/neofs/neofs.go Outdated Show resolved Hide resolved
internal/neofs/neofs.go Outdated Show resolved Hide resolved
internal/neofs/neofs.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 821-s3-panic-on-object-creation branch from 27779de to 1d7ecbe Compare September 12, 2023 10:14
@smallhive smallhive force-pushed the 821-s3-panic-on-object-creation branch from 1d7ecbe to b97b9bf Compare September 12, 2023 12:01
@roman-khimov roman-khimov merged commit 4bad84c into master Sep 12, 2023
10 of 12 checks passed
@roman-khimov roman-khimov deleted the 821-s3-panic-on-object-creation branch September 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 panic on object creation
2 participants
@smallhive @roman-khimov