Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NeoFS SDK with eacl changes #840

Closed
wants to merge 1 commit into from
Closed

Conversation

cthulhu-rider
Copy link
Contributor

Adopt eACL changes.

Signed-off-by: Leonard Lyubich <[email protected]>
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: Patch coverage is 61.84211% with 29 lines in your changes missing coverage. Please review.

Project coverage is 33.85%. Comparing base (1ba680c) to head (7227d33).
Report is 269 commits behind head on master.

Files with missing lines Patch % Lines
authmate/authmate.go 0.00% 14 Missing ⚠️
api/handler/acl.go 78.33% 12 Missing and 1 partial ⚠️
api/layer/container.go 0.00% 1 Missing ⚠️
api/layer/neofs_mock.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
- Coverage   33.86%   33.85%   -0.01%     
==========================================
  Files          62       62              
  Lines       10529    10508      -21     
==========================================
- Hits         3566     3558       -8     
+ Misses       6562     6549      -13     
  Partials      401      401              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

resInfo.Version = filter.Value()
if key := filter.HeaderKey(); key == object.AttributeFilePath {
resInfo.Object = filter.HeaderValue()
} else if key == v2acl.FilterObjectID {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2acl?

@cthulhu-rider
Copy link
Contributor Author

too outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants