Public read acl results in full control permission #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 33.80% 34.39% +0.59%
==========================================
Files 62 62
Lines 10547 10564 +17
==========================================
+ Hits 3565 3634 +69
+ Misses 6578 6524 -54
- Partials 404 406 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
smallhive
force-pushed
the
857-public-read-acl-results-in-full_control-permission
branch
from
1a86673
to
c8e6155
Compare
Closes #857. Signed-off-by: Evgenii Baidakov <[email protected]>
It used only logger, so just passed it as a parameter. Added some tests. Signed-off-by: Evgenii Baidakov <[email protected]>
These changes allow to omit empty fields in response. AWS specification is floating, but in example https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketAcl.html it doesn't return fields with empty values. Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
857-public-read-acl-results-in-full_control-permission
branch
from
c8e6155
to
327d7e0
Compare
roman-khimov
approved these changes
Oct 19, 2023
roman-khimov
deleted the
857-public-read-acl-results-in-full_control-permission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #857