Handle bad user id more gracefully #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old version with type casting doesn't work with wrapped errors. Signed-off-by: Evgenii Baidakov <[email protected]>
Closes #860. Signed-off-by: Evgenii Baidakov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
==========================================
- Coverage 34.45% 34.45% -0.01%
==========================================
Files 62 62
Lines 10573 10577 +4
==========================================
+ Hits 3643 3644 +1
- Misses 6524 6526 +2
- Partials 406 407 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Oct 27, 2023
roman-khimov
deleted the
860-putbucketacl-handle-bad-user-id-more-gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #860