Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not accurate error message for invalid authenticated requests #882

Conversation

smallhive
Copy link
Contributor

Closes #850

Otherwise, wrapper error are not going to be detected.

Signed-off-by: Evgenii Baidakov <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #882 (d703219) into master (fd75a98) will decrease coverage by 0.02%.
Report is 10 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   34.45%   34.44%   -0.02%     
==========================================
  Files          62       62              
  Lines       10573    10579       +6     
==========================================
+ Hits         3643     3644       +1     
- Misses       6524     6528       +4     
- Partials      406      407       +1     
Files Coverage Δ
api/auth/signer/v4/v4.go 6.73% <0.00%> (ø)
api/auth/center.go 15.63% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smallhive smallhive marked this pull request as ready for review October 27, 2023 07:30
@smallhive smallhive force-pushed the 850-not-accurate-error-message-for-invalid-authenticated-requests branch from 61264b0 to 483ce76 Compare October 27, 2023 09:55
Closes #850.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive smallhive force-pushed the 850-not-accurate-error-message-for-invalid-authenticated-requests branch from 483ce76 to d703219 Compare October 27, 2023 10:30
@roman-khimov roman-khimov merged commit 30b5025 into master Oct 27, 2023
11 of 14 checks passed
@roman-khimov roman-khimov deleted the 850-not-accurate-error-message-for-invalid-authenticated-requests branch October 27, 2023 10:36
roman-khimov added a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostObject: not accurate error message for invalid authenticated requests
2 participants