Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store bucket owner pub key in container attributes #915

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

smallhive
Copy link
Contributor

Closes #847.
Closes #857.
Closes #859.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (b20cfa7) 33.78% compared to head (1095dba) 33.68%.
Report is 1 commits behind head on master.

Files Patch % Lines
api/layer/container.go 0.00% 16 Missing ⚠️
api/layer/layer.go 0.00% 9 Missing ⚠️
api/handler/acl.go 76.47% 6 Missing and 2 partials ⚠️
internal/neofs/neofs.go 0.00% 7 Missing ⚠️
api/handler/put.go 0.00% 4 Missing ⚠️
authmate/authmate.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
- Coverage   33.78%   33.68%   -0.10%     
==========================================
  Files          64       64              
  Lines       10799    10844      +45     
==========================================
+ Hits         3648     3653       +5     
- Misses       6745     6783      +38     
- Partials      406      408       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallhive smallhive marked this pull request as ready for review December 13, 2023 08:50
api/layer/container.go Outdated Show resolved Hide resolved
api/layer/neofs_mock.go Show resolved Hide resolved
Permissions read+write are not equals to full_control.

Closes #857.

Signed-off-by: Evgenii Baidakov <[email protected]>
NeoFS is not supporting override ACL rules in container by anonymous. See cd4ddb3#diff-95f9fb7bdd6fbea098329acfc84ab26264360c926d41be2814e38e7a9d5768ffR33

Closes #847.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive smallhive force-pushed the 859-object-default-acl-grants-is-empty branch from af78aaa to 1095dba Compare December 15, 2023 09:52
@roman-khimov roman-khimov merged commit bfa820d into master Dec 15, 2023
11 of 14 checks passed
@roman-khimov roman-khimov deleted the 859-object-default-acl-grants-is-empty branch December 15, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants