.github: update system tests flow for new dev env #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #945 +/- ##
=======================================
Coverage 26.92% 26.92%
=======================================
Files 87 87
Lines 14129 14129
=======================================
Hits 3804 3804
Misses 9903 9903
Partials 422 422 ☔ View full report in Codecov by Sentry. |
evgeniiz321
force-pushed
the
ezayats/ci-new-dev-env
branch
2 times, most recently
from
bce5d3b
to
1584eaa
Compare
smallhive
reviewed
Apr 2, 2024
.github/workflows/system-tests.yml
Outdated
Comment on lines
137
to
148
| cp bin/* ${GITHUB_WORKSPACE}/neofs-testcases/ | ||
| working-directory: neofs-node | ||
|
|
||
| - name: Copy neofs-s3-gw binaries to vendor directory | ||
| - name: Copy neofs-s3-gw binaries to testcases directory | ||
| run: | | ||
| cp bin/* ${GITHUB_WORKSPACE}/neofs-dev-env/vendor/ | ||
| cp bin/* ${GITHUB_WORKSPACE}/neofs-testcases/ | ||
| working-directory: neofs-s3-gw | ||
|
|
||
| ################################################################ | ||
| - name: Chmod binaries | ||
| run: | | ||
| sudo chmod a+x neofs-cli | ||
| sudo chmod a+x neofs-adm | ||
| sudo chmod a+x neofs-ir | ||
| sudo chmod a+x neofs-lens | ||
| sudo chmod a+x neofs-node | ||
| sudo chmod a+x neofs-rest-gw | ||
| sudo chmod a+x neo-go | ||
| sudo chmod a+x neofs-s3-authmate | ||
| sudo chmod a+x neofs-s3-gw | ||
| working-directory: neofs-testcases | ||
|
|
There was a problem hiding this comment.
Maybe, it makes sense to chmod binaries before copying? I mean afters rows 137, 142 make chmod -r a+x ./bin
and then copy updated binaries?
I don't insist, just an another option
There was a problem hiding this comment.
The problem is that binaries come from different places, so it is better to chmod them in one place, just to be sure nothing is left.
smallhive
previously approved these changes
Apr 2, 2024
roman-khimov
reviewed
Apr 2, 2024
evgeniiz321
force-pushed
the
ezayats/ci-new-dev-env
branch
from
1584eaa
to
949bf7d
Compare
Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
force-pushed
the
ezayats/ci-new-dev-env
branch
from
949bf7d
to
d6d4636
Compare
roman-khimov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.