Update ACL structures to have flexible types #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
reviewed
Jun 4, 2024
smallhive
force-pushed
the
863-putbucketpolicy-principal
branch
from
09b4090
to
cab784a
Compare
smallhive
force-pushed
the
863-putbucketpolicy-principal
branch
from
cab784a
to
187c658
Compare
According to AWS docs https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html Action, Principal, Resource may vary by type. It can be string or slice of strings. Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
863-putbucketpolicy-principal
branch
from
187c658
to
f4d62d6
Compare
roman-khimov
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is not solving test issues completely. It gives the ability to use wildcards in
PrincipalandActionfields