Remove actual object version #971
Conversation
api/layer/layer.go
Outdated
| @@ -569,7 +569,7 @@ func (n *layer) deleteObject(ctx context.Context, bkt *data.BucketInfo, settings | |||
| } | |||
|
|
|||
| if obj.DeleteMarkVersion, obj.Error = n.removeOldVersion(ctx, bkt, nodeVersion, obj); obj.Error != nil { | |||
| return obj | |||
| n.log.Error("remove old version", zap.Error(obj.Error)) | |||
There was a problem hiding this comment.
Why does it happen? I'm not sure it's "Error" level, maybe it's perfectly fine in some cases.
There was a problem hiding this comment.
I didn't find the exact reason for the problem, but it is directly connected to the multithreading in the test. Without threads, the code works perfectly. I consider that in some cases not all objects are removed because some error handling returns as here. Well, the error may be too much, replaces with Info.
As minimum, this change doesn't effect current s3 tests
There was a problem hiding this comment.
@smallhive do we know exact obj.Error which caused test failures? May be we can exclude only "normal" errors here
There was a problem hiding this comment.
I tried this approach. The error in this place is Object not found and sometimes Object already removed or something like that.
In this line we are trying to remove some old version. Returning from here allows for the actual version be not removed, and this fix removes all versions.
Anyway, this line fixes the tests and don't mark any other tests with red
Closes #955. Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
955-parallel-deletion-of-versioned-objects
branch
from
e298ae8
to
7bfe508
Compare
Closes #955.