Fs cloning api handler #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
========================================
- Coverage 81.15% 80% -1.16%
========================================
Files 10 10
Lines 467 505 +38
========================================
+ Hits 379 404 +25
- Misses 88 101 +13 |
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 81.15% 82.57% +1.41%
==========================================
Files 10 10
Lines 467 505 +38
==========================================
+ Hits 379 417 +38
Misses 88 88 |
mpacer
force-pushed
the
fs_cloning_api_handler
branch
from
995c781
to
b4b09da
Compare
mpacer
force-pushed
the
fs_cloning_api_handler
branch
from
b4b09da
to
9651f1a
Compare
mpacer
commented
Aug 5, 2019
willingc
approved these changes
Aug 5, 2019
bookstore/clone.py
Outdated
| Returns | ||
| -------- | ||
| dict | ||
| Jupyter Contents API compatible model |
There was a problem hiding this comment.
Link to Contents API https://jupyter-notebook.readthedocs.io/en/stable/extending/contents.html
Co-Authored-By: Carol Willing <[email protected]>
Co-Authored-By: Carol Willing <[email protected]>
willingc
approved these changes
Aug 5, 2019
mpacer
force-pushed
the
fs_cloning_api_handler
branch
from
061f065
to
5b0f704
Compare
mpacer
commented
Aug 5, 2019
|
|
||
| { | ||
| "relpath": string, | ||
| "target_path": string #optional |
There was a problem hiding this comment.
@willingc
Does this successfully capture the idea in a way that would make sense from a python perspective?
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the handler needed to get file system cloning to work.
I will create a separate PR just for adding the handler to the routes and testing the routes.
NB: This is a bit of a bigger PR, but I didn't want to submit a PR for functionality without tests for that functionality.