Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display table data when there are periods in string column names #64

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Jun 28, 2021

Motivation

Testing

📦 Published PR as canary version: 8.2.10--canary.64.d71fcbc.0

✨ Test out this PR locally via:

npm install @nteract/[email protected]
# or 
yarn add @nteract/[email protected]

@hydrosquall hydrosquall added the release Create a release when this pr is merged label Jun 28, 2021
@hydrosquall hydrosquall changed the title [bugfix] Redo #41 - Empty data when there are periods in string column names fix: Display table data when there are periods in string column names Jun 28, 2021
@hydrosquall hydrosquall marked this pull request as ready for review June 28, 2021 19:32
@rgbkrk
Copy link
Member

rgbkrk commented Jun 28, 2021

Nice and clean.

Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @hydrosquall! :shipit:

@hydrosquall hydrosquall self-assigned this Jun 29, 2021
@hydrosquall hydrosquall merged commit afc30dc into main Jun 29, 2021
@github-actions
Copy link

🚀 PR was released in v8.2.10 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants