Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #568 (unexpected id field) #570

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

cristobalcl
Copy link
Contributor

Fix issue #568.

An upgrade is performed after loading the notebook, so Papermill should always work internally with a notebook with the latest version.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is perfect. I tested it out locally and it's working well. Thanks for getting the PR up

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #570 (7049aef) into main (d38d682) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   92.35%   92.37%   +0.01%     
==========================================
  Files          16       16              
  Lines        1413     1416       +3     
==========================================
+ Hits         1305     1308       +3     
  Misses        108      108              

@MSeal MSeal merged commit a4bf8a9 into nteract:main Jan 20, 2021
@MSeal
Copy link
Member

MSeal commented Jan 20, 2021

I'll work on getting a release posting today for this change

@cristobalcl
Copy link
Contributor Author

Cool, happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants