use MaybeUninit type for header parsing. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can probably use hyperium/hyper#2545 as a model for these changes, since it looks like the code is very similar. |
|
thanks |
wpbrown
added a commit
to wpbrown/ntex
that referenced
this pull request
Apr 3, 2023
This reverts commit 114a7b6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use MaybeUninit type for parsing headers and header indices recording.
This would bump MSRV to 1.55 as
MaybeUninit::writeis a safe API stabled at this version. If maintaining current MSRV is important I can make further change and extract the unsafe api under hood.