Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(web-client): fix CI #160

Merged
merged 5 commits into from
Mar 14, 2022
Merged

test(web-client): fix CI #160

merged 5 commits into from
Mar 14, 2022

Conversation

PiDelport
Copy link
Collaborator

@PiDelport PiDelport commented Mar 14, 2022

This makes the CI pass again.

@PiDelport PiDelport added bug Something isn't working M: web-client Module: Web client app (Angular) labels Mar 14, 2022
@PiDelport PiDelport requested a review from a team March 14, 2022 09:45
@PiDelport PiDelport self-assigned this Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022

✔️ Deploy Preview for affectionate-mirzakhani-7a7e75 ready!

🔨 Explore the source changes: 54969ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/affectionate-mirzakhani-7a7e75/deploys/622f261cc0ab410008a895e0

😎 Browse the preview: https://deploy-preview-160--affectionate-mirzakhani-7a7e75.netlify.app

@netlify
Copy link

netlify bot commented Mar 14, 2022

✔️ Deploy Preview for nautilus-wallet ready!

🔨 Explore the source changes: 54969ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/622f261c496679000820d236

😎 Browse the preview: https://deploy-preview-160--nautilus-wallet.netlify.app

@codecov-commenter
Copy link

Codecov Report

Merging #160 (6dcfbaa) into main (5916aea) will decrease coverage by 5.75%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   66.66%   60.91%   -5.76%     
==========================================
  Files          80       77       -3     
  Lines         801      747      -54     
  Branches       85       92       +7     
==========================================
- Hits          534      455      -79     
- Misses        267      292      +25     
Impacted Files Coverage Δ
web-client/src/app/app.module.ts 100.00% <ø> (ø)
web-client/src/app/modules/error-handler.module.ts 100.00% <ø> (ø)
web-client/src/app/views/pay/pay.page.ts 38.77% <0.00%> (ø)
...client/src/app/services/enclave/enclave.service.ts 66.66% <100.00%> (-0.84%) ⬇️
web-client/src/app/views/register/register.page.ts 95.45% <100.00%> (ø)
web-client/src/schema/crypto.ts 100.00% <100.00%> (ø)
web-client/src/app/views/scanner/scanner.page.ts 15.00% <0.00%> (-65.00%) ⬇️
web-client/src/app/open-wallet.guard.ts 75.00% <0.00%> (-10.72%) ⬇️
...views/kyc/onfido-widget/onfido-widget.component.ts 72.22% <0.00%> (-4.25%) ⬇️
.../src/app/views/wallet-access/wallet-access.page.ts 48.48% <0.00%> (-3.13%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e0a54...6dcfbaa. Read the comment docs.

@PiDelport
Copy link
Collaborator Author

This preserves the meaning of the "arrayBuffer" variable.
Upgrading to Angular 13 seems to have broken using templateUrl,
but using an inline template still works, as a workaround for now.
@PiDelport
Copy link
Collaborator Author

Chromatic's passing again. 🎉

@PiDelport PiDelport merged commit d5ac1c5 into main Mar 14, 2022
@PiDelport PiDelport deleted the web-client/fix-ci branch March 14, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working M: web-client Module: Web client app (Angular)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants