Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-client): diasble autologout in send & pull pay #611

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

IscoRuta98
Copy link
Contributor

Aim of this PR is to disable Auto Logout when user is confirming transactions (for pull and pay payments).

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for nautilus-wallet-staging ready!

Name Link
🔨 Latest commit baf7514
🔍 Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64cb56bcc0b9ba00082ca2cf
😎 Deploy Preview https://deploy-preview-611--nautilus-wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IscoRuta98 IscoRuta98 self-assigned this Jul 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #611 (baf7514) into main (58b5197) will decrease coverage by 0.19%.
The diff coverage is 17.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   42.49%   42.31%   -0.19%     
==========================================
  Files         201      201              
  Lines        3490     3505      +15     
  Branches      686      686              
==========================================
  Hits         1483     1483              
- Misses       2007     2022      +15     
Files Changed Coverage Δ
web-client/src/app/services/auto-logout.service.ts 20.37% <16.66%> (-0.04%) ⬇️
web-client/src/app/views/pull/pull.page.ts 22.37% <16.66%> (-0.09%) ⬇️
web-client/src/app/views/pay/pay.page.ts 17.39% <20.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes

@billguo99
Copy link
Contributor

Have you tested this locally?

@IscoRuta98 IscoRuta98 marked this pull request as ready for review August 1, 2023 07:40
@IscoRuta98
Copy link
Contributor Author

Have you tested this locally?

Yes I have. Have you been encountering errors?

Copy link
Contributor

@billguo99 billguo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@billguo99 billguo99 merged commit 6818666 into main Aug 3, 2023
21 checks passed
@billguo99 billguo99 deleted the fix-pull-connector-error branch August 3, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants