Drop support for non-gcrypt builds. #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
force-pushed
the
remove/builds-without-gcrypt-support
branch
from
6649b1c
to
7da26ff
Compare
|
:-) |
two silly one thought =) |
IvanNardi
reviewed
Mar 2, 2022
|
On Wed, Mar 2, 2022, 16:10 Toni ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/ISSUE_TEMPLATE/bug_template.md
<#1469 (comment)>:
> @@ -21,7 +21,7 @@ A clear and concise description of what happening.
* OS version: [e.g. 18.04]
* Architecture: [e.g. arm64]
* nDPI version or commit hash: [e.g. 4.0-stable or 937357e].
-* nDPI compilation flags used: if you are building from source [e.g. --with-pcre --disable-gcrypt].
+* nDPI compilation flags used: if you are building from source [e.g. --with-pcre --with-host-libgcrypt].
Just one nit: using "host" word in configure parameters make me think of
cross-compilation, which is not the case here. Not strong opinion on that
but what about using a different name?
What about local instead of host ?
Better. Thank you
… —
Reply to this email directly, view it on GitHub
<#1469 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBD4J323TGGKRYQKWQZK5DU56AIBANCNFSM5PXNJRCQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
utoni
force-pushed
the
remove/builds-without-gcrypt-support
branch
from
7da26ff
to
0868233
Compare
utoni
force-pushed
the
remove/builds-without-gcrypt-support
branch
3 times, most recently
from
1980a48
to
6834ef9
Compare
* As there is now a builtin, lightweight libgcrypt there is no need to disable tls-clho decryption. * It is still possible to use a host libgcrypt with `--with-local-libgcrypt'. Signed-off-by: Toni Uhlig <[email protected]>
utoni
force-pushed
the
remove/builds-without-gcrypt-support
branch
from
6834ef9
to
5ae637a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
IvanNardi
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no need to disable tls-clho decryption.
with `--with-local-libgcrypt'.
Signed-off-by: Toni Uhlig [email protected]