Replaced ndpiReader's libjson-c support with libnDPI's internal serialization interface. #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
force-pushed
the
fix/ndpi-reader-serialization
branch
2 times, most recently
from
8857764
to
380815b
Compare
IvanNardi
approved these changes
Apr 30, 2022
|
The PR is not ready yet. But will be soon. Thanks for the approval anyway. ;) |
utoni
force-pushed
the
fix/ndpi-reader-serialization
branch
3 times, most recently
from
10b6e99
to
2964710
Compare
|
This pull request introduces 2 alerts when merging 2964710 into 02d0b5f - view on LGTM.com new alerts:
|
utoni
force-pushed
the
fix/ndpi-reader-serialization
branch
2 times, most recently
from
ac6ff03
to
5da360f
Compare
|
Ready for review. A follow-up task: Merge ndpiReader's CSV output ( |
…lization interface. * Fixes ntop#1528 * Serialization Interface should also fuzzed * libjson-c may only be used in the unit test to verify the internal serialization interface * Serialization Interface supports tlv(broken), csv and json * Unit test does work again and requires libjson-c Signed-off-by: lns <[email protected]>
utoni
force-pushed
the
fix/ndpi-reader-serialization
branch
from
5da360f
to
d1b346e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Ready to merge @IvanNardi ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lns [email protected]