Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HTTP lower/upper protocol mess for Aimini/IPP. #1557

Merged
merged 1 commit into from
May 28, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented May 28, 2022

  • If HTTP was already detected, there is no need to overwrite the detection again

Signed-off-by: lns [email protected]

 * If HTTP was already detected, there is no need to overwrite the detection again

Signed-off-by: lns <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue!

@IvanNardi IvanNardi merged commit cfd23e8 into ntop:dev May 28, 2022
@IvanNardi
Copy link
Collaborator

A similar patch might be needed for mpegdash (the attached session is classified as MpegDash/HTTP insted of HTTP/MpegDash).
Unfortunately a trivial fix in ndpi_int_mpegdash_add_connection() triggers a regression in the first flow of mpeg-dash.pcap: MpegDash.AmazonAWS -> HTTP.AmazonAWS (the other 2 flows are fine)

mpeg-dash-2.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants