Added collectd dissector (again). #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 4def22b into 20a29c3 - view on LGTM.com new alerts:
|
utoni
force-pushed
the
add/collectd-protocol
branch
from
4def22b
to
66d4afb
Compare
|
@utoni , all the attached flows are classified as collectd; is that correct or are they false positives? |
|
false positives, need to increase |
Signed-off-by: lns <[email protected]>
utoni
force-pushed
the
add/collectd-protocol
branch
from
66d4afb
to
1987dbc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Thanks for the improvements! |
IvanNardi
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lns [email protected]