Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new flow risk about literal IP addresses used as SNI #1892

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Add a new flow risk about literal IP addresses used as SNI #1892

merged 1 commit into from
Mar 2, 2023

Conversation

IvanNardi
Copy link
Collaborator

@IvanNardi IvanNardi commented Feb 16, 2023 •
edited
Loading

RFC 6066 3: "Literal IPv4 and IPv6 addresses are not permitted in "HostName"."

Don't set this risk if we have a valid sub-classification (example: via certificate)

Since a similar risk already exists for HTTP hostnames, reuse it, with a
more generic name.

@lucaderi
Copy link
Member

@IvanNardi @utoni What about making NDPI_HTTP_NUMERIC_IP_HOST more general?

@IvanNardi
Copy link
Collaborator Author

@IvanNardi @utoni What about making NDPI_HTTP_NUMERIC_IP_HOST more general?

Fine for me. Something like NDPI_NUMERIC_IP_HOST? @lucaderi

@utoni
Copy link
Collaborator

utoni commented Feb 28, 2023

@IvanNardi @utoni What about making NDPI_HTTP_NUMERIC_IP_HOST more general?

Fine for me. Something like NDPI_NUMERIC_IP_HOST? @lucaderi

Makes sense.

@IvanNardi
Add a new flow risk about literal IP addresses used as SNI
efddf33 
RFC 6066 3: "Literal IPv4 and IPv6 addresses are not permitted in
"HostName"."

Don't set this risk if we have a valid sub-classification (example:
via certificate)

Since a similar risk already exists for HTTP hostnames, reuse it, with a
more generic name.
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IvanNardi IvanNardi merged commit 89cae9d into ntop:dev Mar 2, 2023
@IvanNardi IvanNardi deleted the tls-risk-sni-numeri_ip branch March 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utoni utoni utoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanNardi @lucaderi @utoni