Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: improve extraction of metadata and of flow risks #1959

Merged
merged 1 commit into from
May 5, 2023
Merged

HTTP: improve extraction of metadata and of flow risks #1959

merged 1 commit into from
May 5, 2023

Conversation

IvanNardi
Copy link
Collaborator

No description provided.

@IvanNardi IvanNardi marked this pull request as draft April 29, 2023 16:17
@IvanNardi IvanNardi force-pushed the http-rework branch 6 times, most recently from 6c8f68f to 54fa6fb Compare May 1, 2023 19:37
@IvanNardi IvanNardi changed the title HTTP: improve extraction of metadata of flow risks HTTP: improve extraction of metadata and flow risks May 2, 2023
@IvanNardi IvanNardi force-pushed the http-rework branch 3 times, most recently from 55d2492 to d29df85 Compare May 2, 2023 18:05
@IvanNardi IvanNardi changed the title HTTP: improve extraction of metadata and flow risks HTTP: improve extraction of metadata and of flow risks May 2, 2023
@IvanNardi
Copy link
Collaborator Author

IvanNardi commented May 2, 2023 •
edited
Loading

HTTP dissector is probably the most complex one, for historical reasons...
It is not perfect yet (there are some issues with flows starting with a response), but with this change a lot more metadata and flow risks are extracted.
In the unit tests results, the diffs show more information everywhere (with only one exception; see below)
Next step: more clean separation among:

  • protocol identification (request vs reply)
  • lines parsing
  • sub-classification

@IvanNardi IvanNardi marked this pull request as ready for review May 2, 2023 18:12
@IvanNardi IvanNardi force-pushed the http-rework branch 5 times, most recently from a449870 to 7d5ee61 Compare May 3, 2023 17:52
utoni
utoni requested changes May 4, 2023
View reviewed changes
src/lib/protocols/http.c Outdated Show resolved Hide resolved
src/lib/protocols/http.c Show resolved Hide resolved
src/lib/protocols/http.c Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

utoni
utoni approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome, perfect solution!

@IvanNardi IvanNardi merged commit 0223d3c into ntop:dev May 5, 2023
@IvanNardi IvanNardi deleted the http-rework branch May 5, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utoni utoni utoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanNardi @utoni